Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macaw-symbolic: Expose memory model read/write functionality #452

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

RyanGlScott
Copy link
Contributor

This exposes the default implementations of MacawReadMem, MacawWriteMem, and friends as top-level functions in Data.Macaw.Symbolic and exports them. This makes it possible for downstream clients to perform memory reads and writes in a way that respects the macaw-symbolic memory model.

This exposes the default implementations of `MacawReadMem`, `MacawWriteMem`,
and friends as top-level functions in `Data.Macaw.Symbolic` and exports them.
This makes it possible for downstream clients to perform memory reads and
writes in a way that respects the `macaw-symbolic` memory model.
Copy link
Contributor

@langston-barrett langston-barrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that the bodies of the functions were just copy/pasted without signficant changes. If so, LGTM! If not, I can do a more thorough review. Thanks a bunch for the docs!

@RyanGlScott
Copy link
Contributor Author

I'm assuming that the bodies of the functions were just copy/pasted without signficant changes.

Yes, that is correct.

@RyanGlScott RyanGlScott merged commit 4bf0334 into master Nov 26, 2024
4 checks passed
@RyanGlScott RyanGlScott deleted the read-write-mem-model-functions branch November 26, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants