Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Service compatibility check #122

Open
kurtkilpela opened this issue Mar 21, 2022 · 0 comments
Open

Improve Service compatibility check #122

kurtkilpela opened this issue Mar 21, 2022 · 0 comments
Assignees

Comments

@kurtkilpela
Copy link
Member

Service compatibility is current defined as having an equal number of instance variables and a matching template. This isn't sufficient as the names of the variables may have changed or they may have been reorganized.

Instead, we should hash the variable name sequence and include that in the message when serializing a service. The hash should be checked while reifying services. If the check fails, this incompatibility should be reported.

Suggested name of exception: ServiceIncompatibility

@kurtkilpela kurtkilpela self-assigned this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant