Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keeping QgsTask classes in one file consistently #280

Open
Gpetrak opened this issue Nov 1, 2024 · 0 comments
Open

Keeping QgsTask classes in one file consistently #280

Gpetrak opened this issue Nov 1, 2024 · 0 comments
Assignees
@Gpetrak
Labels
enhancement New feature or request
Milestone
2.0.0

Comments

@Gpetrak
Copy link
Contributor

Gpetrak commented Nov 1, 2024 •
edited
Loading

Currently the QgsTask classes (e.g LayerLoaderTask, ThumbnailLoaderTask or NetworkRequestTask) are included in different files (e.g network.py, search_result_widget.py). However, for consistency reasons, we could keep all the QgsTask classes in one file e.g tasks.py.

Also the LayerUploaderTask task could be refactored in order to not include repetitive code which comes from its base class: NetworkRequestTask.
@Gpetrak Gpetrak self-assigned this Nov 1, 2024
@Gpetrak Gpetrak added the enhancement New feature or request label Nov 1, 2024
@Gpetrak Gpetrak mentioned this issue Nov 1, 2024
Closed
@Gpetrak Gpetrak changed the title Keeping QgsTask classes in one file Keeping QgsTask classes in one file consistently Nov 1, 2024
@giohappy giohappy added this to the 2.0.0 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gpetrak Gpetrak

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@giohappy @Gpetrak