Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Avoid stacking dialogs #1037

Open
1 task done
jamiethecat opened this issue Jun 24, 2024 · 3 comments
Open
1 task done

[Request]: Avoid stacking dialogs #1037

jamiethecat opened this issue Jun 24, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@jamiethecat
Copy link
Contributor

Describe the request

Adding a filter in the preferences dialog leads to a dialog opening on a dialog. Consider using inline navigation instead to avoid this.

Implementation Details

@jamiethecat jamiethecat added the enhancement New feature or request label Jun 24, 2024
@GeopJr
Copy link
Owner

GeopJr commented Jun 25, 2024

Inline navigation as in, make the settings window a navigation view or a stack and change to a 'filter' page?

Not opposed to it but in my mind it feels a bit awkward. Do you have an app in mind that follows that pattern?

The 'dialog stacking' pattern can be found in the control center and makes somewhat sense to me there:

image

@jamiethecat
Copy link
Contributor Author

Inline navigation as in, make the settings window a navigation view or a stack and change to a 'filter' page?

Yeah.

The 'dialog stacking' pattern can be found in the control center and makes somewhat sense to me there

We want to move away from stacked dialogs in Settings, and have recently been moving a lot of dialogs to subpages for this reason.

Do you have an app in mind that follows that pattern?

Epiphany, Fractal, Pike Backup, Calendar etc.

@GeopJr
Copy link
Owner

GeopJr commented Jun 25, 2024

I see it on Epiphany and it makes sense, thanks! I had made it look a lot weirder in my mind 😩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants