Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable modules in bot if no configuration is set #108

Open
Montori opened this issue Jun 19, 2021 · 1 comment
Open

Disable modules in bot if no configuration is set #108

Montori opened this issue Jun 19, 2021 · 1 comment
Labels
Architecture Architecture that

Comments

@Montori
Copy link
Collaborator

Montori commented Jun 19, 2021

We have modules like twitch or our chat AI that need specific configuration in our GeraldProperties. If those are not set the whole module wouldn't work. Now it would just stomp our logs full with exceptions that say that we don't have the configuration for that.

In the future we should just disable the whole module if the configuration for it is missing so that a basic selfhosted Gerald is usable without the special config entries

@Montori Montori added the Architecture Architecture that label Jun 19, 2021
@Montori
Copy link
Collaborator Author

Montori commented Jun 19, 2021

I only have a rough idea but lets imagine that we have a twitch modules like the one your are building rn.

All classes will be annotated with @TwitchModule and in the startup of Genevieve we check if the neccessary

requirements are met to run the module and if not we disable it

Discussion about that topic on discord. Should be mentioned in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Architecture that
Projects
None yet
Development

No branches or pull requests

1 participant