Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoremove deleted emotes #91

Closed
ElementalMP4 opened this issue Jun 7, 2021 · 2 comments
Closed

Autoremove deleted emotes #91

ElementalMP4 opened this issue Jun 7, 2021 · 2 comments
Labels
EPIC Big Features Feature

Comments

@ElementalMP4
Copy link
Collaborator

Create a system to automatically remove emotes that do not exist anymore. This may need to be done with a monthly db audit or something, or checked on each Nitrolite message

@ElementalMP4 ElementalMP4 added Feature Awaiting Specs Specifications need to be defined for this issue labels Jun 7, 2021
@Montori
Copy link
Collaborator

Montori commented Jun 19, 2021

We can implement a DelayedTask system (also mentioned in #105) to do a weekly clean up of the emotes. This DelayedTask will run through all of the saved emotes and check against discord if they exist. We may need a different approach tho since I don't think that discord accepts our 4000 requests per milliseconds

@ElementalMP4
Copy link
Collaborator Author

I thought about a solution and I think I have one

We can modify the methods which supply the NitroliteEmote object (which all our emote-based modules use for a standardised format) and when an emote is asked for, we can check to see if it exists by checking the response code of its CDN URL. If there is no emote, it will be immediately deleted, and if searching by name, then we will search for that name again until one is found or there are no by that name left, at which point a filler name will be returned which says Emote No Longer Exists (or similar)

ElementalMP4 pushed a commit that referenced this issue Jul 1, 2021
@ElementalMP4 ElementalMP4 added EPIC Big Features and removed Awaiting Specs Specifications need to be defined for this issue labels Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC Big Features Feature
Projects
None yet
Development

No branches or pull requests

2 participants