Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package broken? #88

Open
Roywcm opened this issue May 27, 2020 · 4 comments
Open

Package broken? #88

Roywcm opened this issue May 27, 2020 · 4 comments
Assignees

Comments

@Roywcm
Copy link

Roywcm commented May 27, 2020

After the latest update, I can't manage to retrieve the feeds? I get feed_slug can only contain alphanumeric characters or underscores on the notification feed and Invalid argument supplied for foreach() on the timeline feed.

I checked and it looks like the config setting key's in StreamLaravelManager.php are not right anymore?

@petrokarpiuk
Copy link
Contributor

petrokarpiuk commented Jun 10, 2020

Having the same issue.
Seems like StreamLaravelManager is trying to access notifications_feed
by using the invalid syntax:

$user_feed = $this->config->get("stream-laravel::notification_feed");

I think it should use "dot" notation instead: stream-laravel.notification_feed

@petrokarpiuk
Copy link
Contributor

petrokarpiuk commented Jun 10, 2020

Created PR - #89

@imam
Copy link

imam commented Jun 21, 2020

Got the same bug, wonder which version caused this

@imam
Copy link

imam commented Jun 21, 2020

So this caused on 2.3.7, I believe the bug made on this commit 0379873 . So... Maybe suggestion for next GetStream updates, please if you want to update something that might broke the current release, update it on the next minor version (v2.4.0), as v2.3.7 should reserve for bug update, pretty dissappointed as it break my site and finding the bug is not easy

imam referenced this issue Jun 21, 2020
fixes issue with config:cache issue #80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants