Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters #30

Closed
Gjum opened this issue Mar 30, 2018 · 1 comment
Closed

Filters #30

Gjum opened this issue Mar 30, 2018 · 1 comment
Labels
Milestone

Comments

@Gjum
Copy link
Owner

Gjum commented Mar 30, 2018

instead of layers #29

  • features show which filters they match, in/excluding filters styled differently, jump to them to edit
  • when rendering map, all active filters compare features by properties, style, geometry, zoom
  • 2 modes: each filter includes or excludes all matching features from being displayed
    • (?) in filter order vs excluding then including vs including then excluding

actions

  • state has list of filters, list of enabled filters
  • filters can be created/deleted
  • filters can be enabled/disabled
  • filters can be merged
  • import/export filters from/to json
  • json import adds known filters and sets active filters
  • find filters matching a particular feature
  • "show all features" switch
    • for when you mess up and need to find which filter hides your feature
    • alternatively use search for finding that hidden feature

figure out

  • gui for filter logic
  • set a filter-specific property when creating new feature, to "group" features into "layers"
    • group_123abc:true - this composes really well
    • groups:[123abc] - difficult to merge
    • complex to explain, is it still usable? hide behind gui magic?
  • no feature ids necessary in export, ids assigned internally only
    • state.features array index - how does deletion work? maybe not allow deletion?
    • where do we even use ids atm? - detail/edit/... gui
    • are ids useful to override features on update? do we want features to be overrideable? mergeable?
      • consider convergence: many people edit a feature, which one will you see
@Gjum Gjum added the 3.0 label Mar 30, 2018
@Gjum Gjum added this to the 3.0 release milestone Mar 30, 2018
@Gjum
Copy link
Owner Author

Gjum commented Mar 30, 2022

use layers #29

@Gjum Gjum closed this as completed Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant