Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VK_RESULT_END_RANGE was removed from vulkan in 1.2.140 #66

Open
federkamm opened this issue Mar 17, 2021 · 1 comment
Open

VK_RESULT_END_RANGE was removed from vulkan in 1.2.140 #66

federkamm opened this issue Mar 17, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@federkamm
Copy link
Contributor

apparently VK_RESULT_END_RANGE does not exist anymore and vuh2 doesn't compile therefore since vulkan 1.2.140. Therefore, the enum VuhError in src/include/vuh/error_code.hpp should use another start value like 10, 11, 100, or 101. Alternatively, it could start from 0 since it looks like the code doesn't depend on VuhError and VkResult not beeing overlapping. How should it be changed?

@Glavnokoman
Copy link
Owner

Vuh code does not depend on VuhError and VkResult to not overlap but it would still be a nice guarantee to have. Cause the user code might happen to introduce that dependency and the bugs would be hard to deal with. I need to think a bit about this. At tend towards the config-time constant with some reasonable default value.

@Glavnokoman Glavnokoman added the bug Something isn't working label Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants