Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named sound id are wrong in some cases #519

Open
Postremus opened this issue Jul 5, 2017 · 2 comments
Open

Named sound id are wrong in some cases #519

Postremus opened this issue Jul 5, 2017 · 2 comments

Comments

@Postremus
Copy link
Contributor

Postremus commented Jul 5, 2017

Hello,

I wanted to implement equipment sounds for armor stand (see #471).
"Sound.ITEM_ARMOR_EQUIP_LEATHER" maps to id "minecraft:item.armor.equip.leather". According to http://pokechu22.github.io/Burger/1.11.html#sounds however, it should be "minecraft:item.armor.equip_leather".

The same is the case for multiple, if not all, of the armor_equip sounds.

regards
Postremus


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@aramperes
Copy link
Member

aramperes commented Jul 5, 2017

return "minecraft:" + sound.name().toLowerCase().replaceAll("_", ".");

We should either have an actual map, or adjust this way of converting to a Vanilla ID.

@mastercoms
Copy link
Member

I honestly think the sounds map is useless for 1.11+, so that should be removed as well. Instead, there should be a map of sound ID exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants