Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passenger are wrongly sent to other players #552

Open
Postremus opened this issue Aug 24, 2017 · 1 comment
Open

Passenger are wrongly sent to other players #552

Postremus opened this issue Aug 24, 2017 · 1 comment

Comments

@Postremus
Copy link
Contributor

Postremus commented Aug 24, 2017

The passengers do net appear to be correctly sent in every case.

To reproduce

  1. Join with multiple accounts
  2. Let account 1 enter a boat, and leave the boat again

Account 2 will see account 1 still sitting in the boat.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@aramperes aramperes changed the title Passenger are wrongly send for other players Passenger are wrongly sent for other players Oct 13, 2017
@aramperes aramperes changed the title Passenger are wrongly sent for other players Passenger are wrongly sent to other players Oct 13, 2017
@notourist
Copy link
Contributor

notourist commented Jan 19, 2018

I did some more testing:

  • If player 1 joins first and player 2 second, player 2 is able to see player 1 leave the vehicle. But if player 2 leaves the vehicle, player 1 won't see this.
  • If the bugged player + vehicle is destroyed, the player gets reset to the vehicles location, just like you would expect.
  • The bugged player can enter other vehicles, but also can't leave them.
  • As far as I can see, it doesn't matter who placed the vehicle.
  • SteerVehicleHandler#handle is NOT fired for the bugged player. I don't know much about Netty/Glowstone's network internals, but this doesn't seem right (because only here GlowEntity#leaveVehicle is used).

Commit: 48cfdfa
Branch: dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants