Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intent to Ship email template does not include reason for why web-platform-tests are not possible #3335

Closed
davidben opened this issue Sep 18, 2023 · 2 comments
Assignees
Labels
bug for-feature-authors process guidance Issues with the launch process or its documentation

Comments

@davidben
Copy link

Describe the bug
The Blink process is designed for the web platform, and thus expects web-platform-tests. WPT is not well-suited for testing networking features, which are web-platform-visible, but below most abstractions in the web platform proper. For example, any features that involve TLS cannot be tested with WPT: web-platform-tests/wpt#20159

The form in chromestatus.com tries to account for this by having both a "Web Platform Tests" checkbox and a freeform "Web Platform Tests Description" field. The latter's description says:

Please link to the results on wpt.fyi. If any part of the feature is not tested by web-platform-tests, please include links to issues, e.g. a web-platform-tests issue with the "infra" label explaining why a certain thing cannot be tested (example), a spec issue for some change that would make it possible to test. (example), or a Chromium issue to upstream some existing tests (example).

However, the Intent-to-Ship email template ignores this field and only displays:

Is this feature fully tested by web-platform-tests?
No

This is confusing to Blink owners, who are now missing important context. The email template should not elide this context.

To Reproduce
Steps to reproduce the behavior:

  1. Launch a networking feature
  2. Leave WPT checkbox off, follow the instructions to link a bug for why WPT is not possible
  3. Send Intent to Ship based on instructions

Expected behavior
Blink owners see the WPT test explanation without having to spend an email round-trip asking why.

@past
Copy link
Collaborator

past commented Oct 4, 2023

@jrobbins is there anything more to be done here?

@jrobbins
Copy link
Collaborator

jrobbins commented Oct 4, 2023

This fix went live last week.

@jrobbins jrobbins closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug for-feature-authors process guidance Issues with the launch process or its documentation
Projects
None yet
Development

No branches or pull requests

4 participants