-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polyfill doesn't work #7
Comments
@dandv PTAL. |
@dandv I can reproduce on https://imagecapture.js.org/ with Safari. Can you have a look at why it fails? |
@KaptenJansson PTAL. |
@beaufortfrancois and @FluorescentHallucinogen: I've merged some PRs to address Safari compatibility. Can you please test the latest build? |
@dandv I opened this issue not because the polyfill didn't work in Safari, but because it didn't work in all (any) browsers that don't support Image Capture API natively (without enabling experimental flags), e.g. Firefox. What was the problem? If the browser support Image Capture API natively then it has What is this polyfill? This polyfill is ES Module that compiled via Babel to UMD module and published to NPM. How users install (use) this polyfill? <script src="https://unpkg.com/image-capture@0.3.5/lib/imagecapture.js"></script> What happens after that? Since the browser don't support Image Capture API natively, it has no I've fixed it 9b27bfd. But I'm not sure if this is the right way? Isn't this a hack? Maybe is there a more elegant way to export (add) |
BTW, please don't use https://imagecapture.js.org to reproduce this problem, because this demo is compiled by Webpack and don't use |
Steps to reproduce:
Expected results without using the polyfill:
Expected results with using the polyfill:
Actual results with using the polyfill:
The text was updated successfully, but these errors were encountered: