Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Prerender Support #348

Closed
2 tasks done
gilbertococchi opened this issue Apr 14, 2023 · 4 comments · Fixed by #352
Closed
2 tasks done

Fix Prerender Support #348

gilbertococchi opened this issue Apr 14, 2023 · 4 comments · Fixed by #352

Comments

@gilbertococchi
Copy link
Contributor

gilbertococchi commented Apr 14, 2023 •
edited
Loading

Now QuickLink limits Prerender to 1 URL and to Same Origin only.

  • 1 URL to Prerender limit should be removed
  • Same Origin should be removed or it should include Same-Site Cross-Origin use case as well

@hadyan @addyosmani FYI
@hadyan hadyan mentioned this issue Apr 19, 2023
Merged
@kireerik
Copy link

Seems like the prerender option is not working.

@XhmikosR
Copy link
Collaborator

@kireerik please make a new issue with as much info as possible.

@hadyan
Copy link
Contributor

hadyan commented Jun 16, 2023

@kireerik please make a new issue with as much info as possible.

+1 @kireerik it will be interesting to take a look at the issue that you are facing with the prerender option if you can share more details (even better if you have a demo page) in the new issue. Thanks.

@kireerik
Copy link

Sure. I have created the new issue:

@hadyan hadyan mentioned this issue Jun 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Prerender Support hadyan/quicklink
4 participants
@gilbertococchi @XhmikosR @kireerik @hadyan