Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

site: use the files from dist folder instead of the CDN #389

Open
XhmikosR opened this issue Jun 16, 2023 · 2 comments
Open

site: use the files from dist folder instead of the CDN #389

XhmikosR opened this issue Jun 16, 2023 · 2 comments
Labels
docs Documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@XhmikosR
Copy link
Collaborator

Not sure how to load the dist folder which is one folder up from site.

This should make sure PR previews use the latest code plus we should be able to add SRI hashes later (see #336).
@XhmikosR XhmikosR added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers docs Documentation labels Jun 16, 2023
@vishalsingh2972
Copy link

@XhmikosR could you provide little more insight on what you want here....want to give it a try!

@XhmikosR
Copy link
Collaborator Author

The issue is because we have the dist folder containing the build files in the root folder, but the site is in the site subfolder. Which means we can't include the dist folder in eleventy since it's outside of the build folder ../dist.

So, we need a robust solution for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@XhmikosR @vishalsingh2972