Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log error (stdout and stderr) on command failures (non-zero exits) for Managed Cloud SDK processes #1008

Open
chanseokoh opened this issue Nov 11, 2019 · 1 comment
Open

Log error (stdout and stderr) on command failures (non-zero exits) for Managed Cloud SDK processes #1008

chanseokoh opened this issue Nov 11, 2019 · 1 comment
Labels
enhancement p3

Comments

@chanseokoh
Copy link
Contributor

Currently, when a command (such as ManagedCloudSDK.isUpToDate()) fails, there is no detailed error message.

See #991 for more details.
@elefeint
Copy link
Contributor

I think this should be resolved here in appengine-plugins-core.

Yes, ManagedSdkVerificationException contains the cause and can return it if prompted, but then it's on the caller (maven and gradle plugins) to get the cause exception, compare its type to CommandExecutionException and get the output.

It would be easier if CommandExecutionException.getErrorLog() got logged before it's wrapped in ManagedSdkVerificationException.

@JoeWang1127 JoeWang1127 transferred this issue from GoogleCloudPlatform/app-gradle-plugin Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement p3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chanseokoh @elefeint