Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secure-cloud-run should expose the timeout_seconds input to secure-cloud-run-core #224

Open
massfords opened this issue Aug 6, 2024 · 2 comments · May be fixed by #225
Open

secure-cloud-run should expose the timeout_seconds input to secure-cloud-run-core #224

massfords opened this issue Aug 6, 2024 · 2 comments · May be fixed by #225

Comments

@massfords
Copy link

I am using the secure-cloud-run module but find that I need to modify the timeout for the cloud run service it creates.

There is an input variable defined for this in secure-cloud-run-core with a 2 minute default, but I don't see this variable included in the inputs for the wrapper module secure-cloud-run.

Unless I'm mistaken, I can't do this without the wrapper module including timeout_seconds in its variables.tf and also passing it into its invocation of the secure-cloud-run-core module.

Copy link

github-actions bot commented Oct 5, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Oct 5, 2024
@massfords
Copy link
Author

There is an open PR for this issue at #225 but it looks like there are issues with the build since nearly all the PR's in this project have failing builds.

I've worked around the need for secure-cloud-run exposing this variable by copying the entirety of the cloud run terraform scripts into my project but it would be nice to avoid adding all of this code just to set a single property.

@github-actions github-actions bot removed the Stale label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant