Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does my PiSSA init process so slow? #19

Open
ANYMS-A opened this issue Jul 1, 2024 · 3 comments
Open

Why does my PiSSA init process so slow? #19

ANYMS-A opened this issue Jul 1, 2024 · 3 comments

Comments

@ANYMS-A
Copy link

ANYMS-A commented Jul 1, 2024

Hey, I recently tried to use PiSSA init during the LoRA finetuing process, however I noticed that the time takes to init with PiSSA is so long.
I set all linear layer as my LoRA target layer and the Rank of the LoRA is 32. I used "pissa_niter_4" as the init_lora_weights argument, but seems it still takes about 20-30 minutes, is there any solutions for this ? Many thanks!

@fxmeng
Copy link
Collaborator

fxmeng commented Jul 5, 2024

The execution time of (Fast) SVD is related to the dimensions of the matrices. Could you please specify which model you are using?

@ANYMS-A
Copy link
Author

ANYMS-A commented Jul 7, 2024

Hey thanks for the reply. I used the DeepSeek-v1.5 for the finetuning. One thing I observed is that: if I set the 'bias' as 'lora-only' when using pissa, the unit process will be slow, but if I set it to none, the init process of pissa will be much faster. BTW
I use a Lora rank of "32"

@beyondguo
Copy link

beyondguo commented Dec 6, 2024

Same problem. It's even quite when I was finetuning Roberta.

I guess it's related to the CPU? Cause this happens on my Intel(R) Xeon(R) Platinum 8268 CPU @ 2.90GHz machine, but much faster on the Intel(R) Xeon(R) Platinum 8458P machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants