Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the "Unapproved" filter to count entries without the is_approved meta as well #2247

Open
omarkasem opened this issue Dec 30, 2024 · 0 comments · May be fixed by #2248
Open

Change the "Unapproved" filter to count entries without the is_approved meta as well #2247

omarkasem opened this issue Dec 30, 2024 · 0 comments · May be fixed by #2248
Assignees

Comments

@omarkasem
Copy link
Collaborator

omarkasem commented Dec 30, 2024

Copied from https://github.com/GravityKit/GravityImport/issues/468

Steps to reproduce

With GravityView inactive, submit one entry in a form
Enable GravityView
Check the Unapproved filter, the entry will not be listed there
The filter only counts entries containing the is_approved meta with a value of 3.

This affects entries imported with GravityImport. When importing new entries using GravityImport, the is_approved entry meta is not created unless the user's CSV explicitly provides and maps a column for it.

This may cause confusion for users because the Unapproved counter in the Gravity Forms entries interface does not work as expected if the approval meta is missing:

355463799-272e1b24-70e9-4396-8a16-039a83219704

The current solution when importing entries with GravityImport is to require the customer to manually add an approval status column to their CSV or use the gravityview/import/entry/created hook to set the approval meta.

However, that's not intuitive and it doesn't sound right to require customers to add entry meta for unapproved entries to make our approval system work as expected. They don't need to do this when submitting a form.

Slack discussion:
https://gravitykit.slack.com/archives/C727B06MB/p1722947461675509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant