-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Resume from Replay #91
Comments
We can parse these replays now but the fact that new players took control part way through the game is completely ignored. We need a good way to make this information available. |
The information is exposed in a very basic way now with the following added to the replay: #: True of the game was resumed from a replay
resume_from_replay = False
#: A flag marking which method was used to resume from replay. Unknown interpretation.
resume_method = None
#: Lists info for each user that is resuming from replay.
resume_user_info = None The user info can't really be applied at this point because it is incomplete. Specifically, the user's toon_id, region, and subregion are missing. Without this information we can't really tell who the new user really is. Putting on hold for now, hopefully Blizzard can add this information in the future. |
This toon, region, and subregion information can be extracted from the toon_handle for each user: Example 1-S2-1-390979:
This information could be extracted and packaged to create new Player/Observer objects for the game. How exactly to expose this isn't settled yet. |
The resume_from_replay flag doesn't seem to work for me. It's always false. Is it meant to be working yet? |
Please attach an example replay and state your sc2reader version when reporting issues. If the replay is private you can email it to me. |
Sorry I figured out it was because I had load_level=3. I didn't realise that this information required the game events to be loaded :) |
I found this issue with resumed replays. Haven't dug into it much but here is a stacktrace and its pretty obvious what file it blew up on:
|
Totally failing right now.
The text was updated successfully, but these errors were encountered: