Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min Python version to 3.10 is a problem for Netlify users #292

Closed
brabster opened this issue Jun 12, 2024 · 7 comments · Fixed by #304
Closed

Min Python version to 3.10 is a problem for Netlify users #292

brabster opened this issue Jun 12, 2024 · 7 comments · Fixed by #304
Assignees
Labels
dependencies Pull requests that update a dependency file question Further information is requested

Comments

@brabster
Copy link

Hi there,

I use Netlify to run my site and unfortunately they currently only support Python 3.8 https://docs.netlify.com/configure-builds/available-software-at-build-time/. I see a move to 3.10 min in my branch that I just synced with main and boom

image

I'm not sure if updating past 3.8 is an option on Netlify, can't see a way. Had to pin back to an earlier commit to get back up and running. Might cause some problems if there's a lot of folks using it

@Guts
Copy link
Owner

Guts commented Jun 14, 2024

Hello,

I did not planned to make this change and I would prefer to follow the EOL planning of Python releases as usual but I've been facing a bug with Mkdocs modern typed config objects. I've to take the time to investigate and file the issue upstream.

I'm using Netlify to generate preview of my website on PR and I set the Python version in a runtime.txt file as described in https://docs.netlify.com/configure-builds/manage-dependencies/#python.

@Guts Guts added question Further information is requested dependencies Pull requests that update a dependency file labels Jun 14, 2024
@Guts Guts self-assigned this Jun 14, 2024
@brabster
Copy link
Author

brabster commented Jun 14, 2024

Oh could you share your Netlify runtime.txt that works? I tried contents '3.10" but it failed to build with the version not found. I figured you could only choose from the two versions Netlify mention but if I can pin it forward I'll do that!

@Guts
Copy link
Owner

Guts commented Jun 14, 2024

@brabster
Copy link
Author

Hmm, that's exactly what I tried in my PR earlier this week, both 3.10 and 3.11 brabster/tw-site-mkdocs@0d7dbf4, Netlify build broke

failing netlify builf log mentioning Python 3.10

I don't see any significant different in what you do vs. what I do. If you get a minute could you share a Netlify deploy log, initializing step, under 3.10 for comparison? I'm currently stuck unable to sync to your main, I guess if you're going to flip it back to 3.8 compatible eventually it's not a big deal but I like to be up to date if possible

@Guts
Copy link
Owner

Guts commented Jun 24, 2024

I've restored the compatibility with Python 3.8 and 3.9 in 1.3.4 with the help of mkdocs/mkdocs#3753 (comment).

Can you try it and give me feedback here please @brabster?

@brabster
Copy link
Author

Hey @Guts thank you for making these changes. I've synced up to main now and my Netlify builds are working fine 🙏

I have mentioned this extra work you had to do on the Netlify community forums.

@Guts
Copy link
Owner

Guts commented Jun 25, 2024

Hey @Guts thank you for making these changes. I've synced up to main now and my Netlify builds are working fine 🙏

Good news! Sorry again for the troubled temporary situation.

I have mentioned this extra work you had to do on the Netlify community forums.

Thanks you, I think it's valuable to give an overview of consequences of their choices regarding the build stack. But I have to say that I would make the same choices here: using the oldest supported Python version by default and allowing the end-user to pick up a specific version. Well, it's a shame if this last option does not work as expected.

If your website code is on GitHub (or GitLab), it's pretty fair simple to build and host on it. Not so optimized for sure (Netlify and Jamstack do an incredible work on static content) but mostly enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants