Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Use torchdim instead of Storchastics plating system #103

Open
HEmile opened this issue Jun 28, 2022 · 0 comments
Open

Refactor: Use torchdim instead of Storchastics plating system #103

HEmile opened this issue Jun 28, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@HEmile
Copy link
Owner

HEmile commented Jun 28, 2022

Storchastic uses a rather intricate system for batching over multiple dimensions, but it's rather buggy and hard to work with for end users.
Recently PyTorch 1.12 introduced torchdim with first-class dimension objects that should serve the same purpose as plates in Storchastic. We will likely have much cleaner, easier to read, write and debug and faster code by adopting this new standard. See
https://colab.research.google.com/drive/1BsVkddtVMX35aZAvo2GyI-wSFPVBCWuA#scrollTo=8511a637

It implements

  • Implicit batching: Two batch dimensions are joined together, just like in Storchastic.
  • Mixed named tensors: Only batch dimensions need to be named, event dimensions in Storchastic can just be numeric
@HEmile HEmile added the enhancement New feature or request label Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant