favicons-webpack-plugin@5 slows build down a lot

[derhuerst]

Follow-up of #4607.

It is hard to compare to the previous version(s) directly, given that the new favicons-webpack-plugin@5 doesn't work with the old Webpack and vice versa, but it causes a build slowdown of about 2 minutes. We should investigate why it is so slow.

[kymppi]

If this is still an issue. I can try to take a look :)

[derhuerst]

Sure, if you want to. All relevant changes currently reside in the node-migration branch.

[kymppi]

Okay thanks

[kymppi]

It will take a few days since the nodejs version 10 has to be manually built in nixos. And I don't want to spend hours doing that. Ill be on my Arch Linux machine in few days so i can get nodejs 10 working 🥲

[derhuerst]

@kymppi You don't need Node 10 anymore: favicons-webpack-plugin@5 is only used in the "upgraded" dev setup on the node-migration branch which relies on Node.js v16.

[kymppi]

@kymppi You don't need Node 10 anymore: favicons-webpack-plugin@5 is only used in the "upgraded" dev setup on the node-migration branch which relies on Node.js v16.

Ohh thanks, I just tried to follow the instructions in docs/Installation.md. I'll try again right now 😄

[kymppi]

I seem to get this error with any node version I try:

Uncaught (in promise) Error: Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
Error: Package subpath './package.json' is not defined by "exports" in /home/midka/git/digitransit-ui/node_modules/postcss/package.json
at new NodeError (node:internal/errors:387:5)
at throwExportsNotFound (node:internal/modules/esm/resolve:439:9)
at packageExportsResolve (node:internal/modules/esm/resolve:718:3)
at resolveExports (node:internal/modules/cjs/loader:493:36)
at Function.Module._findPath (node:internal/modules/cjs/loader:533:31)
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:942:27)
at Function.Module._load (node:internal/modules/cjs/loader:804:27)
at Module.require (node:internal/modules/cjs/loader:1022:19)
at require (node:internal/modules/cjs/helpers:102:18)
at Object. (/home/midka/git/digitransit-ui/node_modules/postcss-loader/dist/index.js:12:39)