Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use profile for importer in e2e setup script #33

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

culka
Copy link
Contributor

@culka culka commented Sep 19, 2024

This change is Reviewable

Add a default 'false' input value which determines if jore3 importer
and mssql should be started along other services in e2e setup.
Copy link

@Huulivoide Huulivoide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @culka)

@culka culka force-pushed the use-profile-for-importer-e2e branch from 36c3fbf to de48a7a Compare September 19, 2024 09:49
@culka culka changed the title Switch e2e setup to use docker compose Use profile for importer in e2e setup script Sep 19, 2024
@culka culka merged commit aa13164 into main Sep 19, 2024
16 of 17 checks passed
@culka culka deleted the use-profile-for-importer-e2e branch September 19, 2024 09:59
Copy link

@Huulivoide Huulivoide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants