Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dirichlet initialization should take the log of the samples before setting the parameters #12

Closed
orsharir opened this issue Jun 4, 2017 · 1 comment
Closed

Dirichlet initialization should take the log of the samples before setting the parameters #12

orsharir opened this issue Jun 4, 2017 · 1 comment
Assignees
@elhanan7
Labels
bug

Comments

@orsharir
Copy link
Member

orsharir commented Jun 4, 2017

In your current Dirichlet initialization code, the returned init is simply the samples from the Dirichlet distribution, but it should be the log of the samples instead. See #8 for a fixed initializer code.
@orsharir orsharir added the bug label Jun 4, 2017
@orsharir orsharir mentioned this issue Jun 4, 2017
Closed
@elhanan7
Copy link
Contributor

elhanan7 commented Jun 6, 2017

Solved in commit 3ab9acb

@elhanan7 elhanan7 closed this as completed Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elhanan7 elhanan7

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orsharir @elhanan7