Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for shape sizes and for correctly setting parameters #15

Open
orsharir opened this issue Jun 23, 2017 · 0 comments
Open
Assignees

Comments

@orsharir
Copy link
Member

Given the cause of issue #8, I suggest you add unit tests for correct setting of input parameters and shapes. E.g. check that when you set unshared/shared weights the parameters size is correct -- do not use the functions you've written to handle this, but instead have hard coded values for a few cases. Do the same for other parameters (block, pooling, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants