Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate bootstrap.css and spur.css #1

Open
visavi opened this issue Jan 10, 2019 · 3 comments
Open

separate bootstrap.css and spur.css #1

visavi opened this issue Jan 10, 2019 · 3 comments

Comments

@visavi
Copy link

visavi commented Jan 10, 2019

Mixing and editing bootstrap is bad practice, it’s better that they are separated and the styles overlap the original

@arechsteiner
Copy link
Member

Bad practice? Would you source or reason this claim?

Editing Bootstrap the way I'm doing it is documented here: https://getbootstrap.com/docs/4.2/getting-started/theming/

I'm simply adding the spur stuff afterwards so I can use the variables and mixins in spur as well without much fuss. I'm not sure what benefit splitting up the customized Bootstrap and the Spur styles would bring. Spur relies on Bootstrap 100%.

@visavi
Copy link
Author

visavi commented Jan 10, 2019

If you abandon the project, it will be hard to upgrade to the new bootstrap version.
here for example
https://stackoverflow.com/questions/20721248/how-can-i-override-bootstrap-css-styles

@arechsteiner
Copy link
Member

That is indeed a drawback but I don't see a way around it.

Overwriting all the Bootstrap styles manually just doesn't make sense if Bootstrap has this powerful theming infrastructure where you set one variable and then all the buttons look differently.

For other projects doing bootstrap.css and custom.css as in the StackOverflow thread is great, but that threat is also from 2013 when Bootstrap didn't have such a good customization setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants