-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate bootstrap.css and spur.css #1
Comments
Bad practice? Would you source or reason this claim? Editing Bootstrap the way I'm doing it is documented here: https://getbootstrap.com/docs/4.2/getting-started/theming/ I'm simply adding the spur stuff afterwards so I can use the variables and mixins in spur as well without much fuss. I'm not sure what benefit splitting up the customized Bootstrap and the Spur styles would bring. Spur relies on Bootstrap 100%. |
If you abandon the project, it will be hard to upgrade to the new bootstrap version. |
That is indeed a drawback but I don't see a way around it. Overwriting all the Bootstrap styles manually just doesn't make sense if Bootstrap has this powerful theming infrastructure where you set one variable and then all the buttons look differently. For other projects doing |
Mixing and editing bootstrap is bad practice, it’s better that they are separated and the styles overlap the original
The text was updated successfully, but these errors were encountered: