Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check ALL_PARAMETERS #12

Open
andrescvargasr opened this issue Sep 16, 2022 · 0 comments
Open

Check ALL_PARAMETERS #12

andrescvargasr opened this issue Sep 16, 2022 · 0 comments
Assignees
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@andrescvargasr
Copy link
Contributor

Param.h > ALL_PARAMETERS stores all the pin for every probes (pH, EC, temp1, temp2, battery), but actually we used this array like a check in acquire.h > acquire(), in this case, we check the actual value (< 128 in previous version) and ACTIVE_PARAMETERS, now, if we have the pin instead a number of bitmask, we have trouble with this code.

Option 1: Remove ALL_PARAMETERS and use PARAM_ACTIVE_PROBES instead.

Option 2: Refactor ALL_PARAMETERS for compatibility with simple-spectro project.

@andrescvargasr andrescvargasr added bug Something isn't working invalid This doesn't seem right labels Sep 16, 2022
@andrescvargasr andrescvargasr self-assigned this Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant