Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RecursiveBinder.Spoon init.lua #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update RecursiveBinder.Spoon init.lua #324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Source/RecursiveBinder.spoon/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,11 +257,15 @@ function obj.recursiveBind(keymap)
local func = obj.recursiveBind(map)
-- key[1] is modifiers, i.e. {'shift'}, key[2] is key, i.e. 'f'
modal:bind(key[1], key[2], function() modal:exit() killHelper() func() end)
modal:bind(obj.escapeKey[1], obj.escapeKey[2], function() modal:exit() killHelper() end)

-- Repeated binding, resulting in slowdown
-- modal:bind(obj.escapeKey[1], obj.escapeKey[2], function() modal:exit() killHelper() end)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to just remove this, rather than commenting it out.

if #key >= 3 then
keyFuncNameTable[createKeyName(key)] = key[3]
end
end
-- fix repeat bind
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment isn't helpful - it would be better to say what is happening now, rather than what was fixed.

For example:

-- Bind Escape key to exit modal

modal:bind(obj.escapeKey[1], obj.escapeKey[2], function() modal:exit() killHelper() end)
return function()
modal:enter()
killHelper()
Expand Down