Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n message key being returned as error message #11

Open
TheMeinerLP opened this issue Apr 29, 2024 · 6 comments
Open

i18n message key being returned as error message #11

TheMeinerLP opened this issue Apr 29, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@TheMeinerLP
Copy link

TheMeinerLP commented Apr 29, 2024

Description:
When uploading a release with a non-existent channel, only an i18n string is returned instead of a meaningful message.

Steps to reproduce:

  1. Use hangar publish plugin
  2. set channel to something that makes no sense
  3. try to release

Expected behaviour:

  1. a message saying that the channel is not available

Repo+Commit: https://github.com/OneLiteFeatherNET/CoinCoffer/blob/22ba84bea7402230b660bcf75939aad32e033d3e/coincoffer-patches/build.gradle.kts.patch#L70

Images:
image

@jpenilla jpenilla added the bug Something isn't working label Apr 29, 2024
@MiniDigger
Copy link
Member

meh, idk what we would do here. the backend returns those by design, the frontend does the translation. maybe when we fixed crowdin we can download the english file into the gradle plugin or something, but like, the error is understandable, your channel has no color

@TheMeinerLP
Copy link
Author

The actual error was that I had capitalised it instead of lower case. But I got the error message for colour.

@MiniDigger
Copy link
Member

well, "yes". you entered a channel that didnt exist, it tried to create a new channel, that failed because no color.

@TheMeinerLP
Copy link
Author

Wouldn't it make more sense from my point of view to say that the channel must exist instead of displaying the colour error message?

@MiniDigger
Copy link
Member

well, creating a new channel on upload is a feature.

@TheMeinerLP
Copy link
Author

Then I would rather ask, is it also possible to specify the colour in the plugin if it is a feature?

@MiniDigger MiniDigger changed the title No correct error messages when uploading a release i18n message key being returned as error message May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants