-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve variable naming. #1
Comments
Hi @HarshKapadia2 @tusharnankani 👋 Thanks for the suggestions! Would you like to submit a PR for any of this? I would be obliged for the purpose 😄 |
Sure @HarshCasper, I wouldn't mind submitting a PR. I'll do it on the 17th if that's okay with you, as I have end semester exams going on. Sorry! |
Please take your time! Best of luck with your exams :) |
Hey @HarshCasper I was working on this issue, but I had a doubt. Where are the following environment variables being set? validate-issues-over-pull-requests/main.py Lines 15 to 16 in 1b3d410
I'm asking because I want to rename them to |
Hey @HarshCasper any updates? |
Hi @HarshKapadia2 — Apologies for the late response. Here are the references:
I hope it makes sense now. Please let me know if you have any further questions and I will respond over quickly (subscribed to this conversation). |
Any news on this? @HarshKapadia2 |
Nice Action!
In my opinion, variables like
prbody
,prurl
andPRNUM
would be more readable if they had underscores (_
) or hyphens (-
) to separate them.prurl
➡️pr-url
(underscore didn't look good to me here)prbody
➡️pr-body
(underscore didn't look good to me here)PRNUM
➡️PR_NUM
(hyphen didn't look good to me here)Cc: @tusharnankani
The text was updated successfully, but these errors were encountered: