Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Level 2 Development Hit List #36

Open
13 tasks done
skuhlmann opened this issue Oct 30, 2024 · 8 comments
Open
13 tasks done

Complete Level 2 Development Hit List #36

skuhlmann opened this issue Oct 30, 2024 · 8 comments
Assignees

Comments

@skuhlmann
Copy link
Contributor

skuhlmann commented Oct 30, 2024

DAO Home

  • change active proposal count to all proposal
  • Active Proposals intent if proposalCount if more than 0
    - link to proposals route + query there and display latest or none
  • intent View all link to admin
  • members and safes intents

To Do

  • how will we handle stale active proposals
  • proposals route that checks and sends to another route?
    • look into frog middleware

Proposal

  • execute intent if in that state
  • intent to proposal details

Vote

  • add status
  • hide tx intent if not voting
  • add execute if needs processing
  • maintain proposal pagination on back button

success

  • rework usage

Add networks

  • all supported

Update routing

  • match daohaus v3 app
 "eip155:1" - mainnet
"eip155:10" - op
"eip155:100" - gnosis chain
"eip155:8453" - base
"eip155:42161" - arb
137 - polygon
@skuhlmann skuhlmann self-assigned this Oct 30, 2024
@earth2travis earth2travis changed the title Frame Dev - Milestone 1 Hit List Complete Milestone 2 Development Hit List Oct 30, 2024
@skuhlmann
Copy link
Contributor Author

skuhlmann commented Oct 31, 2024

broken

  • no vote
  • no proposal states
  • proposal details link went to dao overview
  • voting grace status times

@earth2travis earth2travis changed the title Complete Milestone 2 Development Hit List Complete Level 2 Development Hit List Nov 3, 2024
@earth2travis
Copy link
Contributor

On the DAO Overview frame update the Members intent to go to the Members view of the DAO. Right now it is pointing to Proposal Details

http://localhost:5173/molochv3/0xa/0x2a244bb4ccd4eb0897cf61e0c61963e1e1d161e3

@earth2travis
Copy link
Contributor

Image

Let's shorten the description on the proposals

@earth2travis
Copy link
Contributor

The proposals details intent does not seem to be pointing to the proposal displayed in the frame. When viewing proposal 2:

Image

The Details intent opens proposal 3:

https://admin.daohaus.club/#/molochv3/0xa/0x2a244bb4ccd4eb0897cf61e0c61963e1e1d161e3/proposal/3

@earth2travis
Copy link
Contributor

The proposals details intent does not seem to be pointing to the proposal displayed in the frame. When viewing proposal 4:

Image

The Details intent opens members:

https://admin.daohaus.club/#/molochv3/0xa/0x2a244bb4ccd4eb0897cf61e0c61963e1e1d161e3/members

@earth2travis
Copy link
Contributor

On the execution frame

Image

The details intent currently points to the Members view of DAOhaus Admin

@earth2travis
Copy link
Contributor

The success view on the Execute frame needs to be updated to point to execute: 'Proposal Executed',

It currently shows:

Image

@earth2travis
Copy link
Contributor

On this proposals view:

Image

There is one proposal that needs to be executed and one that failed. Ideally if there is one that needs execution the intent would go to the proposal. If that is too complicated NBD

However, the link from the proposals intent is pointing to: https://admin.daohaus.club/#/molochV3/0xa/0x2a244bb4ccd4eb0897cf61e0c61963e1e1d161e3/proposal/2

It should be pointing to: https://admin.daohaus.club/#/molochv3/0xa/0x2a244bb4ccd4eb0897cf61e0c61963e1e1d161e3/proposals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants