Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors after running npm run new:example command #2366

Open
JakeSaintG opened this issue Nov 26, 2024 · 0 comments
Open

Errors after running npm run new:example command #2366

JakeSaintG opened this issue Nov 26, 2024 · 0 comments
Assignees

Comments

@JakeSaintG
Copy link
Collaborator

Summary

When attempting to create an example for the breadcrumbs, I got an error from the npm run new:example command. The error comes from new-example.ts, line 30, where it attempts to run Object.keys over a undefined or null object from the package.json. It expects a peerDependencies obj to exist in the cashmere-example project's package.json. Additionally, if the npm run new:example does succeed, subsequent runs or running npm install causes a package mismatch erro rin the cashmere-examples package.json and package-lock.json.

Reproduction
Steps to reproduce:

  1. Running npm run new:example will immediately cause the error to happen.
  2. If the command succeeds (either by having a peerDeps obj or defaulting to an empty array), running the command again or running npm i will cause the package mismatch error.

Additional context
I have an existing branch with a fix that defaults to an empty array if the package.json does not have a peerDependencies obj. Additionally, I am testing a solution or two to the package mismatch issue. I hope to make a PR with the fixes to this issue very soon.

@JakeSaintG JakeSaintG self-assigned this Nov 26, 2024
JakeSaintG added a commit to JakeSaintG/Fabric.Cashmere that referenced this issue Dec 19, 2024
Add default to ex deps, update ex proj cashmere ver, & script alteration to lock file.

fix HealthCatalyst#2366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant