Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MiniMessage support for item display names, lores and menu titles #15

Open
BlitzOffline opened this issue Dec 23, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@BlitzOffline
Copy link
Member

While the Spigot API does not support Adventure, we can still try to add support for it.

One way to support this would be to do a double translation: MiniMessage String -> Adventure Component -> Legacy String.
The downsides of this would be that components/tags such as translatable, keybind, etc. would not be supported.

I was told that this can also be achieved using reflection and that https://github.com/TriumphTeam/triumph-gui/ does exactly this.

One thing I want to make clear is that only one option will be supported at a time. Menu creators won't be able to combine Legacy Strings with MiniMessage Strings. They will be able to toggle the option they want to use per plugin and not per menus inside "config.yml". By default Legacy Strings will be used to offer backwards support.

@Starmism Starmism added the enhancement New feature or request label Dec 30, 2023
@BlitzOffline BlitzOffline changed the title Add MiniMessage support for item display names and lores Add MiniMessage support for item display names, lores and menu titles Feb 29, 2024
@GG-MD
Copy link

GG-MD commented Aug 30, 2024

Do it already! It's been years, we've been waiting years!!! @BlitzOffline

@GG-MD
Copy link

GG-MD commented Sep 19, 2024

@BlitzOffline

I've organized you a 1/5 grade on Spigot, maybe that will speed up the process somehow. 🤦🏽‍♂️

@BlitzOffline
Copy link
Member Author

Unfortunately you will have to continue waiting. We are maintaining this project out of our free time which we don't have a lot of. We are not getting paid and we do not plan on getting paid for this work and there is just so much we can do. If this feature is a deal breaker for you I'm afraid you will have to look for alternatives. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants