Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Both slo_forward_on_logout and slo_forwad_on_logout are required to prevent redirect #58

Open
jeffmaley opened this issue Sep 16, 2020 · 1 comment

Comments

@jeffmaley
Copy link

It looks like the remediation from (#40) has resulted in both variables being required or the samlauthenticator looks for the SingleSignOut in the metadata. With only one set (it doesn't matter which), the following shows up the logs:

[D 2020-09-16 16:43:43.808 JupyterHub samlauthenticator:711] Got metadata etree
[D 2020-09-16 16:43:43.808 JupyterHub samlauthenticator:717] Got valid metadata etree
[D 2020-09-16 16:43:43.809 JupyterHub samlauthenticator:723] Final xpath is: //md:SingleLogoutService[@binding='urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect']/@location
[E 2020-09-16 16:43:43.809 JupyterHub web:1792] Uncaught exception GET /hub/logout (72.21.198.66)
HTTPServerRequest(protocol='http', host='jupyter3.domain.tld', method='GET', uri='/hub/logout', version='HTTP/1.1', remote_ip='72.21.198.66')
Traceback (most recent call last):
File "/opt/jupyterhub/lib64/python3.7/site-packages/tornado/web.py", line 1703, in _execute
result = await result
File "/opt/jupyterhub/lib64/python3.7/site-packages/samlauthenticator/samlauthenticator.py", line 852, in get
logout_handler_self)
File "/opt/jupyterhub/lib64/python3.7/site-packages/samlauthenticator/samlauthenticator.py", line 729, in _get_redirect_from_metadata_and_redirect
handler_self.redirect(redirect_link_getter(saml_metadata_etree)[0], permanent=False)
IndexError: list index out of range

@distortedsignal
Copy link
Contributor

This is going to be fixed in the v1 release when slo_forwad_on_logout is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants