Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Any info about HOTFIX about infinite edge code? #16

Open
Neinndall opened this issue Aug 28, 2023 · 5 comments
Open

[Question] Any info about HOTFIX about infinite edge code? #16

Neinndall opened this issue Aug 28, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@Neinndall
Copy link

Neinndall commented Aug 28, 2023

Describe the bug
After the last changes to infinite edge, it is slow too run, and has several console errors with the .svg, .webm, .jpg files, it seems that some addresses in the program are wrong and makes INFINITE EDGE try those addresses when they are badly structured.

Here is the case that i explain. It seems that the first case is the ERROR in the console, and below is the successful download without errors with the proper address.

This is a example for soul fighter event:

Here is example of somes .webm files errors in console:

image

/landing-button-video-left.webm --> this is link address in the tool that do error in the console
_/lib-embed/videos/landing-button-video-left.1158f6.webm --> This is the link that seems to be correct.

Here is example of somes .svg files errors in console:

image

and .jpg, .png files usually happens too, not in many cases, but it usually happens in someones.

Obviously this means that if you do the first few cases and these errors appear in the console, these attempts are wasted time, so you should only download the .webm files with the appropriate address, so as not to cause these errors and waste of time.

I hope it can be fixed soon.

thx!

@Neinndall Neinndall added the bug Something isn't working label Aug 28, 2023
@Hi-Ray
Copy link
Owner

Hi-Ray commented Sep 3, 2023

We attempt to download these files in the event they exist i don't really see the issue here

@Neinndall
Copy link
Author

Normally there are svg files that are downloaded, but from what I have seen, they are usually the ones that are named with many characters with numbers and letters, the ones that are named normally are never downloaded

image

@Hi-Ray
Copy link
Owner

Hi-Ray commented Sep 4, 2023

These are svgs found in thee code and the names are the contents hashed using md5 as for the svgs not found i will look into this

@Neinndall
Copy link
Author

Neinndall commented Sep 16, 2023

I did a little test by making a small modification to the following.

const pathRegex = /"\.?([\w\.\/-]*\.(?:jpg|png|gif|webm|svg|webp|ogg|json))/g; to const pathRegex = /"\.?([\w\.\/-]*\.(?:jpg|png|gif|webm|webp|ogg|json))/g;

It seems that at first it makes the first attempts with their names, which FAIL, in the end it downloads it successfully, by removing "svg" from that part, the failed attempts at the beginning are eliminated. I don't know if this could be useful.
I checked that by removing "svg" from there, no svg file was left undownloaded and that's right, the console errors are eliminated and everything is downloaded successfully.

@Hi-Ray
Copy link
Owner

Hi-Ray commented Sep 16, 2023

You just removed the search for svgs so you did nothing useful, I still don't see the issue here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants