Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port pdb.rs from nom to binrw #45

Closed
Holzhaus opened this issue Feb 24, 2022 · 7 comments · Fixed by #64
Closed

Port pdb.rs from nom to binrw #45

Holzhaus opened this issue Feb 24, 2022 · 7 comments · Fixed by #64

Comments

@Holzhaus
Copy link
Owner

@Swiftb0y is working on a PoC: #39 (comment)

@Swiftb0y
Copy link
Contributor

Reporting the progress just so you won't think I vanished:
I took a slightly different approach compared to #47. I think I got a working implementation for reading and writing (!) DeviceSQL strings. I wrote the string as their own standalone module. I will open a PR as soon as I wrote enough unit tests to be confident for the implementation to be correct. I don't know how much time I'll have during this weekend, so don't expect a PR before tuesday.

@Swiftb0y
Copy link
Contributor

Swiftb0y commented Mar 9, 2022

I'm now working on an implementation strategy for Rows. If they contain more than one column that contains strings, they are allocated at the end of the row and addressed using an offset. This more or less forces the use of a FilePtr which can't do serialization yet (see jam1garner/binrw#4). After spending a couple days trying to find a workaround, I decided to give up and just implement this read-only until an upstream solution has been found.

@Holzhaus
Copy link
Owner Author

Ok, could you open a draft PR?

@Swiftb0y
Copy link
Contributor

Unfortunately I still haven't gotten anywhere. I caught covid a week earlier and now I've got other priorities. The only progress I made so far can be sketched out in a couple of lines. I'll open a PR later today.

@Holzhaus
Copy link
Owner Author

I caught covid a week earlier

Sorry to hear that. I hope you get well soon!

@Swiftb0y
Copy link
Contributor

Thanks, I'm healthy again but I need to work through the backlog of tasks that accumulated during that week until I can shift my focus back to the more time-consuming work related to rekordcrate

@Swiftb0y
Copy link
Contributor

I'm giving up on this issue for now. I'm not making any progress and there is too much going on IRL for me atm. Feel free to takeover if you have time. I'm sorry. Thanks for your understanding.

Holzhaus added a commit that referenced this issue Apr 3, 2022
Holzhaus added a commit that referenced this issue Apr 7, 2022
Holzhaus added a commit that referenced this issue Apr 8, 2022
Holzhaus added a commit that referenced this issue Apr 8, 2022
The binrw-based parser is now feature complete and can replace the nom-based
parser. Fixes #45.
Holzhaus added a commit that referenced this issue Apr 11, 2022
Holzhaus added a commit that referenced this issue Apr 11, 2022
The binrw-based parser is now feature complete and can replace the nom-based
parser. Fixes #45.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants