Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SupportsConfigFeatureAll is needed #332

Open
sjhill01 opened this issue Jan 4, 2023 · 4 comments
Open

SupportsConfigFeatureAll is needed #332

sjhill01 opened this issue Jan 4, 2023 · 4 comments
Labels
Jira This issue has been linked to a Jira issue To Do This issue is in need of attention

Comments

@sjhill01
Copy link
Contributor

sjhill01 commented Jan 4, 2023

Environment

HomeSeer

OS

Any

HS Version

v4.2.16.0

Development

PSDK Version

v1.4.2.0

Language

VB

IDE

VS2022

Dev OS

Windows

Plugin

Device History

Problem

Description

In the HS3 version of the plugin, one of the features my users like is the ability to go to the "Device History" tab of any device that's been configured for monitoring by the plugin and see the recent values and changes. Using SupportsConfigDeviceAll solved this in HS3, but in HS4 the reference passed in to GetJuiDeviceConfigPage is the Device, not the selected Feature. Despite the requests in #86 and #157 to have a method that simply passes in both, the solution to #86 was to implement SupportsConfigDevice. That would be fine for some use cases, but that means my plugin doesn't get called because it has no claim on the feature.

Expected Behavior

Either create a new method "SupportsConfigAll" that sends in both the device ref and the feature ref for any device/feature, or implement a SupportsConfigFeatureAll that behaves similarly to SupportsConfigFeature but without the requirement of the feature being managed by the plugin.

Steps to Reproduce

  1. Create a plugin with the intent of showing information about all features.
  2. Discover there's no way to do that.

Screenshots

N/A

Logs

N/A

@sjhill01 sjhill01 added the To Do This issue is in need of attention label Jan 4, 2023
@alexbk66
Copy link

alexbk66 commented Jan 4, 2023

AbstractPlugin has SupportsConfigDeviceAll already, I'm using it in my AKSmartDevice plugin

image

image

@spudwebb
Copy link
Collaborator

spudwebb commented Jan 4, 2023

Tracked as PSDK-308 and HS-1774

@sjhill01
Copy link
Contributor Author

@alexbk66 I need SupportsConfigFeatureAll.

@alexbk66
Copy link

@alexbk66 I need SupportsConfigFeatureAll.

Ok, my bad

@spudwebb spudwebb added the Jira This issue has been linked to a Jira issue label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira This issue has been linked to a Jira issue To Do This issue is in need of attention
Projects
None yet
Development

No branches or pull requests

3 participants