Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workshop full uses old version of istio 1.1.5 #40

Open
csantanapr opened this issue Jun 13, 2020 · 3 comments · May be fixed by #41
Open

workshop full uses old version of istio 1.1.5 #40

csantanapr opened this issue Jun 13, 2020 · 3 comments · May be fixed by #41

Comments

@csantanapr
Copy link

workshop full https://github.com/IBM/cloud-native-starter/blob/master/workshop/00-prerequisites.md

Uses old version of istio 1.1.5 and this fails on new versions of k8s 1.16+ as Deployment is not part of apps/beta1

IKS doc uses istio 1.5.1, so as good step forward it would be good to keep all 3 places using same version of Istio between minikube and IKS

@csantanapr csantanapr linked a pull request Jun 13, 2020 that will close this issue
@thomassuedbroecker
Copy link
Collaborator

thomassuedbroecker commented Jun 15, 2020

@csantanapr Thanks for the comment I will change first to 1.5.1.

thomassuedbroecker added a commit that referenced this issue Jun 15, 2020
@csantanapr
Copy link
Author

Hi @thomassuedbroecker I submitted a PR at the time I opened the issue two days ago here #41

Would be awesome if you could review it and allow other folks to contribute to the this repository.

@thomassuedbroecker
Copy link
Collaborator

thomassuedbroecker commented Jun 15, 2020

Hi @csantanapr, sure I only noticed the issue. The review will take more time and thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants