cloud-native-starter/reactive - minor issues on set up scripts

[mishijima]

Hello.

First of all, thank you for the 'reactive' sample project. It helps me understand better on reactive applications.

That being said, I followed the steps in the README and encountered a few minor issues.

My O/S: macOS Big Sur

1. I have a fish shell installed and am using it as my default shell. When I executed the script that contains 'eval (...)' it threw the following, even after I swapped to bash

bash-3.2$ sh scripts/deploy-authors.sh 
2021-08-04 13:18:24 Deploying authors
scripts/deploy-authors.sh: line 15: set: -g: invalid option
set: usage: set [--abefhkmnptuvxBCHP] [-o option] [arg ...]

bash-3.2$ echo $SHELL
/usr/local/bin/fish

I am not sure why even though '#!/bin/bash' is specified in the script. But, it looks like the solution is just to specify the shell inside the 'eval'. For example,

eval $(minikube docker-env --shell bash)

Full credit to docker/machine#4035 (comment) for the above solution.

2. When I ran the 'deploy-postgres-admin.sh', the pod didn't want to get started and throws an error.

'admin' does not appear to be a valid email address. Please reset the PGADMIN_DEFAULT_EMAIL environment variable and try again.

I think it's because the kubedb pgadmin.yaml -> 'PGADMIN_DEFAULT_EMAIL' doesn't use an email. Hence, when I tried it with an email address it worked.

I have attached a patch file to this issue because I thought someone else might encounter the same issues as I did, and the patch might help them.

Thanks again for this sample project.

minor-adjustments.patch.zip

[thomassuedbroecker]

Hi @mishijima, thanks for your feedback. We have to check it. Regards Thomas