Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open issues for ACT implementation inconsistencies #2030

Closed
2 tasks done
philljenkins opened this issue Sep 9, 2024 · 10 comments
Closed
2 tasks done

Open issues for ACT implementation inconsistencies #2030

philljenkins opened this issue Sep 9, 2024 · 10 comments
Assignees
Labels
ACT Issues/Rules related to ACT engine Issues in the accessibility-checker-engine component SME Discuss with subject matter experts T63

Comments

@philljenkins
Copy link
Contributor

philljenkins commented Sep 9, 2024

  • Review inconsistencies and
  • open issues against ACT and/or Checker to resolve the 5 remaining inconsistent rules.

Current reported status from Checker v 3.1.77

The test results were last updated 7 November 2024.
Screenshot 2024-09-09 at 1 12 21 PM

References

@philljenkins philljenkins self-assigned this Sep 9, 2024
@philljenkins
Copy link
Contributor Author

This was not part of original work estimated for 6.3 release

@shunguoy shunguoy added T63 engine Issues in the accessibility-checker-engine component SME Discuss with subject matter experts ACT Issues/Rules related to ACT labels Sep 9, 2024
@philljenkins
Copy link
Contributor Author

This issue will be much easier and faster when #2004 is completed.

@philljenkins
Copy link
Contributor Author

philljenkins commented Oct 10, 2024

Summary of inconsistent ACT rules below (updated with 7 November results):

  • Failed examples should be failed by at least one of the Checker rules fail reason codes.
  • Checker should be mapping (report against) the same success criteria as what is expected by the ACT rule.
  1. Partial: Element marked as decorative is not exposed 46ca7f:

    • Mapping: The Checker implementation reports different success criteria as failed from what is expected by this rule. Checker reports 1.1.1 while ACT expects None.
    • aria_attribute_valid: Pass, Fail_invalid_role_attr, Fail_invalid_implicit_role_attr and maps ARIA same as ACT.
    • "failed correctly by " img_alt_null: potential_aria_override on Failed Example 2, but maps to 1.1.1
    • Mapping: This rule reports 1.1.1 while ACT expects None. This rule & reason code should map to ARIA, not 1.1.1.
    • opened issue fixrule(img_alt_null) Maps to 1.1.1 while ACT expects None #2089
  2. Partial: Image has non-empty accessible name 23a2a8:

  3. Partial: Scrollable content can be reached with sequential focus navigation 0ssw9k:

  4. Partial: Meta element has no refresh delay (no exception) bisz58 with 3 test cases:

  5. Partial: Orientation of the page is not restricted using CSS transforms b33eff:

@shunguoy
Copy link
Contributor

focus on API differences.

@philljenkins
Copy link
Contributor Author

Using new Rules mapping spreadsheet auto-built Artifact for each PR Action

@philljenkins
Copy link
Contributor Author

Checker info from Rules mapping spreadsheet

img_alt_null potential_aria_override When the intent is to mark an image as decorative with an empty 'alt' attribute, the 'aria' or 'title' attributes should not be used The image 'alt' attribute is empty, but the 'aria' label is not empty and overrides the 'alt' attribute Violation Potential 1 1.1.1 46ca7f:fail

@MHoov
Copy link

MHoov commented Nov 4, 2024

@philljenkins what is the status?

@philljenkins philljenkins mentioned this issue Nov 5, 2024
6 tasks
@philljenkins
Copy link
Contributor Author

Waiting on the latest Rules mapping spreadsheet auto-built Artifact for the latest PR Action

@philljenkins
Copy link
Contributor Author

philljenkins commented Nov 12, 2024

Now updated 7 November for v 3.1.77 release (build):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACT Issues/Rules related to ACT engine Issues in the accessibility-checker-engine component SME Discuss with subject matter experts T63
Projects
None yet
Development

No branches or pull requests

3 participants