-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Property naming conventions for vapor pressure and saturation vapor pressure #1481
Comments
@kurbansitterley I think the source of your confusion is that you are thinking of a fairly specific use case where as the IDAES names are general (i.e. they have no concept of a liquid surface, boundary layer or anything like that). Note that "vapor pressure" is somewhat ambiguous (hence the IDAES names), as there are different states at which you might want the partial pressure of a component. Thus, we went with somewhat more technical, but hopefully more specific naming.
Hopefully that clears things up a bit. R.e. |
And an after thought - the above assumes only a vapor phase is present. If you have a multiphase system then you would want |
@andrewlee94 I appreciate the response and had not thought of I have opened #1482 to address the |
Yes, it should be |
I have
relative_humidity = vapor_pressure / saturated_vapor_pressure
.According to the IDAES docs page on IDAES property naming conventions,
vapor_pressure
should bepressure_sat
, which I am not sure I understand (sincevapor_pressure
would not be saturated unless relative humidity is 100%... or maybe I am missing something). But then does that meansaturated_vapor_pressure
should bepressure_sat_equil
? In this case,vapor_pressure
is the partial pressure of water under given conditions andsaturated_vapor_pressure
is the vapor pressure of water in equilibrium with an open liquid surface.I suppose the issue here is:
pressure_sat
on the docs page should bepressure_vap
(or something else)_sat
... or really how the IDAES community feels about this in general?conc_phase_comp['liq', 'H2O']
as a valid property name, but does concentration not require a basis? What would be the units of such a property?Or maybe there is a different way to do it that would adhere to the conventions as they are already laid out?
(This may be better suited as a discussion rather than an issue so I am happy to move it if so)
The text was updated successfully, but these errors were encountered: