From a5274a6e926a490f30debfa5474f6fb1c0fd50ac Mon Sep 17 00:00:00 2001
From: JulienThevenozIMRC <julien@thevenoz.ch>
Date: Fri, 15 Dec 2023 15:24:58 +0100
Subject: [PATCH] experiment

---
 .github/workflows/systemtests.yml |  3 ++-
 systemtests/test_flights.py       | 18 +++++++++++++-----
 2 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/systemtests.yml b/.github/workflows/systemtests.yml
index c8ac91fad..045b64049 100644
--- a/.github/workflows/systemtests.yml
+++ b/.github/workflows/systemtests.yml
@@ -43,9 +43,10 @@ jobs:
 
       - name: Upload files
         id: step6
+        if: '!cancelled()'
         uses: actions/upload-artifact@v3
         with:
-          name: pdf_bagfiles_and_logs
+          name: pdf_rosbags_and_logs
           path: |
             ros2_ws/results
           
diff --git a/systemtests/test_flights.py b/systemtests/test_flights.py
index f2ce6cd05..50f858f08 100644
--- a/systemtests/test_flights.py
+++ b/systemtests/test_flights.py
@@ -138,6 +138,14 @@ def translate_plot_and_check(self, testname:str) -> bool :
         plotter.create_figures(self.test_file, rosbag_csv, output_pdf) #plot the data
         return plotter.test_passed()
 
+    def test_hello_world(self):
+        #this is not a fully functionning test at the moment (it supposes the hello_world ideal trajectory is figure8 so of course it a always fail)
+        self.test_file = "../crazyflie_examples/crazyflie_examples/data/figure8.csv"
+        # run test
+        self.record_start_and_clean("hello_world", 40)
+        #create the plot etc
+        test_passed = self.translate_plot_and_check("hello_world")
+        #assert test_passed, "hello_world test failed : deviation larger than epsilon"
 
 
     def test_figure8(self):
@@ -148,11 +156,11 @@ def test_figure8(self):
         test_passed = self.translate_plot_and_check("figure8")
         assert test_passed, "figure8 test failed : deviation larger than epsilon"
 
-    def test_multi_trajectory(self):
-        self.test_file = "../crazyflie_examples/crazyflie_examples/data/multi_trajectory/traj0.csv"
-        self.record_start_and_clean("multi_trajectory", 80)
-        test_passed = self.translate_plot_and_check("multi_trajectory")
-        assert test_passed, "multitrajectory test failed : deviation larger than epsilon"
+    # def test_multi_trajectory(self):
+    #     self.test_file = "../crazyflie_examples/crazyflie_examples/data/multi_trajectory/traj0.csv"
+    #     self.record_start_and_clean("multi_trajectory", 80)
+    #     test_passed = self.translate_plot_and_check("multi_trajectory")
+    #     assert test_passed, "multitrajectory test failed : deviation larger than epsilon"