Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crazyflie_py: fix flake8 and pep256 issues #321

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Conversation

whoenig
Copy link

@whoenig whoenig commented Oct 23, 2023

No description provided.

@whoenig whoenig marked this pull request as ready for review October 23, 2023 12:01
@whoenig
Copy link
Author

whoenig commented Oct 23, 2023

Hi @knmcguire, this is one of 3 PRs that essentially enable Python code linting for crazyswarm2 (using mostly flake8). Since the tests where failing before, quite many (whitespaces) changes were needed. Thanks for double checking!

Copy link
Collaborator

@knmcguire knmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I'm not surprised.... I don't think I've done many flake8 and pep256 tests for the code but let's start doing that now. Are these tests part of the ROS distro checks too?

@whoenig
Copy link
Author

whoenig commented Oct 24, 2023

These tests are the default ones that get created when you create a new package (I deleted one check, that checks that every file has some "copyright information", because I believe that having a LICENSE per repo is sufficient). We just had those tests disabled, because well - they failed:-)

@whoenig whoenig merged commit d0e5f05 into main Oct 24, 2023
2 checks passed
@whoenig whoenig deleted the feature_crazyfliepy_flake8 branch October 24, 2023 10:44
boomer319 pushed a commit to boomer319/verrueckterschwarm2 that referenced this pull request Nov 25, 2023
crazyflie_py: fix flake8 and pep256 issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants