From c29f0e16fd48eb8669442c901ca48db295bbe431 Mon Sep 17 00:00:00 2001 From: Wolfgang Hoenig Date: Wed, 21 Feb 2024 07:19:09 +0100 Subject: [PATCH 1/2] Docs: hint to explicitly build in release mode See also https://github.com/colcon/colcon-cmake/issues/96 --- .github/workflows/systemtests.yml | 2 +- .github/workflows/systemtests_sim.yml | 2 +- docs2/installation.rst | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/systemtests.yml b/.github/workflows/systemtests.yml index 1cae1631a..dc2d7f34d 100644 --- a/.github/workflows/systemtests.yml +++ b/.github/workflows/systemtests.yml @@ -30,7 +30,7 @@ jobs: run: | source /opt/ros/humble/setup.bash cd ros2_ws - colcon build --symlink-install + colcon build --symlink-install -DCMAKE_BUILD_TYPE=Release - name: Flight test id: step5 diff --git a/.github/workflows/systemtests_sim.yml b/.github/workflows/systemtests_sim.yml index 75a84d912..4ef5f583e 100644 --- a/.github/workflows/systemtests_sim.yml +++ b/.github/workflows/systemtests_sim.yml @@ -48,7 +48,7 @@ jobs: run: | source /opt/ros/humble/setup.bash cd ros2_ws - colcon build --symlink-install + colcon build --symlink-install -DCMAKE_BUILD_TYPE=Release - name: Flight test id: step6 diff --git a/docs2/installation.rst b/docs2/installation.rst index 325bb73f0..72bd74f8a 100644 --- a/docs2/installation.rst +++ b/docs2/installation.rst @@ -51,7 +51,7 @@ First Installation .. code-block:: bash cd ../ - colcon build --symlink-install + colcon build --symlink-install -DCMAKE_BUILD_TYPE=Release .. note:: symlink-install allows you to edit Python and config files without running `colcon build` every time. @@ -99,7 +99,7 @@ You can update your local copy using the following commands: git submodule sync git submodule update --init --recursive cd ../../ - colcon build --symlink-install + colcon build --symlink-install -DCMAKE_BUILD_TYPE=Release .. Once you have completed installation, From 0e15e749dfacd50aad8ddac0d86a038329345b31 Mon Sep 17 00:00:00 2001 From: Wolfgang Hoenig Date: Wed, 21 Feb 2024 08:53:39 +0100 Subject: [PATCH 2/2] fix typo --- .github/workflows/systemtests.yml | 2 +- .github/workflows/systemtests_sim.yml | 2 +- docs2/installation.rst | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/systemtests.yml b/.github/workflows/systemtests.yml index dc2d7f34d..68f851ef5 100644 --- a/.github/workflows/systemtests.yml +++ b/.github/workflows/systemtests.yml @@ -30,7 +30,7 @@ jobs: run: | source /opt/ros/humble/setup.bash cd ros2_ws - colcon build --symlink-install -DCMAKE_BUILD_TYPE=Release + colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release - name: Flight test id: step5 diff --git a/.github/workflows/systemtests_sim.yml b/.github/workflows/systemtests_sim.yml index 4ef5f583e..439c4ad17 100644 --- a/.github/workflows/systemtests_sim.yml +++ b/.github/workflows/systemtests_sim.yml @@ -48,7 +48,7 @@ jobs: run: | source /opt/ros/humble/setup.bash cd ros2_ws - colcon build --symlink-install -DCMAKE_BUILD_TYPE=Release + colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release - name: Flight test id: step6 diff --git a/docs2/installation.rst b/docs2/installation.rst index 72bd74f8a..d9cf15381 100644 --- a/docs2/installation.rst +++ b/docs2/installation.rst @@ -51,7 +51,7 @@ First Installation .. code-block:: bash cd ../ - colcon build --symlink-install -DCMAKE_BUILD_TYPE=Release + colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release .. note:: symlink-install allows you to edit Python and config files without running `colcon build` every time. @@ -99,7 +99,7 @@ You can update your local copy using the following commands: git submodule sync git submodule update --init --recursive cd ../../ - colcon build --symlink-install -DCMAKE_BUILD_TYPE=Release + colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release .. Once you have completed installation,