Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter functionality #137

Open
MirandaEcho opened this issue May 27, 2020 · 2 comments
Open

Filter functionality #137

MirandaEcho opened this issue May 27, 2020 · 2 comments
Milestone

Comments

@MirandaEcho
Copy link
Collaborator

Confirmed filter functionality:

  • Type of organization will be a dropdown/single select.
  • Category/tag will be a dropdown, limit of 3 selections, all results much contain all selected terms (AND) so that selecting multiple tags further narrows search results.
  • We will also update the no results found message to say something like "please try reducing the number of selected tags to see more results).
@MirandaEcho MirandaEcho added this to the INOV-001 milestone May 27, 2020
@benlk
Copy link
Collaborator

benlk commented May 28, 2020

Starting a branch for this off of #134; we can decide tomorrow morning whether to merge that or if there's anything else that needs to be done in it.

@benlk
Copy link
Collaborator

benlk commented Jun 5, 2020

  • - submit the form when the <select> changes
  • - track whether the inputs in the details element are changed, and how many are checked
  • - when the <details> element is closed or otherwise onBlur, if the inputs there are changed, submit the search
  • - limit the number of checked inputs to no more than 3: if it's 3, disable all inputs until one is unchecked
  • - add note to bottom or top of details saying it's limited to three

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants