Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COE being called during multi model setup? #84

Open
clegaard opened this issue Mar 22, 2020 · 4 comments
Open

COE being called during multi model setup? #84

clegaard opened this issue Mar 22, 2020 · 4 comments
Milestone

Comments

@clegaard
Copy link
Contributor

It seems the COE is being queried during the multi model setup, even if its not installed yet.

image

Conceptually this is flawed. If the application strictly requires the COE to be installed, it should be shipped with the application.
If the COE is optional the application should not assume it to be present before the co-simulation is invoked.

Can anyone shed some light on this?

@clagms
Copy link

clagms commented Mar 22, 2020

I think that a multi-model is useless without the COE, right?
Assuming this is the case (I'm really not sure), then it does not bother me so much that there are some queries there.

@clegaard
Copy link
Contributor Author

The argument can be extended to the whole application. It can be argued that it is useless without an COE.

At a practical level, the issue is that these error messages are being generated at a very high rate drowning out any real faults in the software.

@CThuleHansen
Copy link

CThuleHansen commented Mar 24, 2020

This does not look like a COE issue. It looks more like a fmu loading issue.

Looks like it is here:
https://github.com/INTO-CPS-Association/into-cps-application/blob/development/src/angular2-app/coe/models/Fmu.ts#L64-L70

@clegaard
Copy link
Contributor Author

It seems so. It assumed that since the js file was in the coe directory it was related to the coe, but it looks like it is not the case.

@idhugoid idhugoid added this to the 4.0.2 milestone Nov 12, 2020
@idhugoid idhugoid modified the milestones: 4.0.2, 9.9.9 Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants