Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Dataset Use Case hierarchy property persistentId missing #154

Closed
g-saracca opened this issue May 16, 2024 · 3 comments
Closed

Get Dataset Use Case hierarchy property persistentId missing #154

g-saracca opened this issue May 16, 2024 · 3 comments
Labels
bug Something isn't working pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 10 A percentage of a sprint. 7 hours.

Comments

@g-saracca
Copy link
Contributor

g-saracca commented May 16, 2024

Overview of the Feature Request

The response of the Get Dataset use case does not correctly send the persistentId of the dataset within the hierarchy property.
Instead, it is sending the persistentId as an id property, and persistentId is being sent as undefined.
See property hierarchy in the use case response.

{
    ...restOfProperties,
    
    "hierarchy": {
        "name": "Dataset from GS",
        "type": "dataset",
        "id": "doi:10.5072/FK2/WMJULU",
        "persistentId": undefined,
        "version": ":draft",
        "parent": {
            "name": "GS Dataverse",
            "type": "collection",
            "id": "gdataverse",
            "parent": {
                "name": "Root",
                "type": "collection",
                "id": "root"
            }
        }
    }
}

What Inspired the Request?

What Existing Behavior Do You Want Changed?

Correctly send persistentId property in hierarchy object of a dataset.

Any Brand New Behavior Do You Want to Add to js-dataverse?

None

Any Open or Closed Issues Related to This Feature Request?

Extend BreadcrumbsGenerator for action Items

@g-saracca g-saracca added bug Something isn't working Size: 10 A percentage of a sprint. 7 hours. pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows labels May 16, 2024
@g-saracca g-saracca changed the title Get Dataset Use Case hierarchy property persistentId missing. Get Dataset Use Case hierarchy property persistentId missing May 16, 2024
@ekraffmiller ekraffmiller self-assigned this May 20, 2024
@ekraffmiller
Copy link
Contributor

ekraffmiller commented May 21, 2024

The bug was in the mapping code of the SPA, rather than in the js-dataverse use case. Here is a PR for the fix: IQSS/dataverse-frontend#404

@g-saracca
Copy link
Contributor Author

Thanks @ekraffmiller!

@ekraffmiller
Copy link
Contributor

Issue resolved, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 10 A percentage of a sprint. 7 hours.
Projects
None yet
Development

No branches or pull requests

2 participants