Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date format validation in create/edit dataset use cases #157

Closed
GPortas opened this issue Jun 25, 2024 · 0 comments · Fixed by #161
Closed

Fix date format validation in create/edit dataset use cases #157

GPortas opened this issue Jun 25, 2024 · 0 comments · Fixed by #161
Labels
bug Something isn't working FY25 Sprint 1 FY25 Sprint 1 GREI Re-arch GREI re-architecture-related Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA: Create Dataset Page SPA: Edit Dataset Page SPA.Q3 Not related to any specific Q3 feature

Comments

@GPortas
Copy link
Contributor

GPortas commented Jun 25, 2024

Overview of the feature request

Not all metadata fields of all metadata blocks expect a date in the YYYY-MM-DD format. There are metadata fields that expect other date formats, defined by the watermark.

For example, the journalPubDate field also accepts YYYY or YYYY-MM, and currently if these formats are added, js-dataverse returns the following error:

There was an error when validating the field journalPubDate from metadata block journal with parent field journalVolumeIssue in position 0. Reason was: The field requires a valid date format (YYYY-MM-DD).

Fix this to support the formats provided by the watermark field.

What inspired the request?

Edit dataset use case integration

What existing behavior do you want changed?

Edit and create dataset validations

Any brand new behavior do you want to add to js-dataverse?

None

Any open or closed issues related to this feature request?

None

@GPortas GPortas added bug Something isn't working Size: 10 A percentage of a sprint. 7 hours. SPA: Create Dataset Page SPA: Edit Dataset Page GREI Re-arch GREI re-architecture-related labels Jun 25, 2024
@cmbz cmbz added the FY25 Sprint 1 FY25 Sprint 1 label Jul 10, 2024
@g-saracca g-saracca self-assigned this Jul 15, 2024
@g-saracca g-saracca removed their assignment Jul 16, 2024
@GPortas GPortas added SPA.Q3 Not related to any specific Q3 feature Original size: 10 labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FY25 Sprint 1 FY25 Sprint 1 GREI Re-arch GREI re-architecture-related Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA: Create Dataset Page SPA: Edit Dataset Page SPA.Q3 Not related to any specific Q3 feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants