From 52b907114ce7e1238361661d25d6b1a54697c701 Mon Sep 17 00:00:00 2001 From: Joel Gomes da Silva Date: Sun, 21 Jan 2024 14:33:48 -0300 Subject: [PATCH 1/2] doc: fix plugin file name in build instructions --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 3e9cddb..15b1342 100644 --- a/README.md +++ b/README.md @@ -79,7 +79,7 @@ In short follow these steps: - Linux: - `./gradlew assembleRelease` - Copy the newly created `.aar` file to your plugin directory: - - `app/build/outputs/aar/GodotPlayGamesServices.release.aar` to `[your Godot project]/android/plugins/` + - `app/build/outputs/aar/GodotGooglePlayGameServices.release.aar` to `[your Godot project]/android/plugins/` # How to use From bc4e9a766dadb31e9d4ec9b7c8f2304e1eddafd4 Mon Sep 17 00:00:00 2001 From: Joel Gomes da Silva Date: Sun, 21 Jan 2024 14:34:26 -0300 Subject: [PATCH 2/2] fix: null uri causing crashes --- .../godot/gpgs/games/GameMapper.kt | 30 ++++++++----------- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/app/src/main/java/com/jacobibanez/godot/gpgs/games/GameMapper.kt b/app/src/main/java/com/jacobibanez/godot/gpgs/games/GameMapper.kt index fcd3224..a174bbc 100644 --- a/app/src/main/java/com/jacobibanez/godot/gpgs/games/GameMapper.kt +++ b/app/src/main/java/com/jacobibanez/godot/gpgs/games/GameMapper.kt @@ -17,22 +17,16 @@ fun fromGame(godot: Godot, game: Game) = Dictionary().apply { game.secondaryCategory.let { put("secondaryCategory", it) } put("themeColor", game.themeColor) put("hasGamepadSupport", game.hasGamepadSupport()) - game.hiResImageUri.let { - put( - "hiResImageUri", - it.toStringAndSave(godot, "hiResImageUri", game.applicationId) - ) - } - game.iconImageUri.let { - put( - "iconImageUri", - it.toStringAndSave(godot, "iconImageUri", game.applicationId) - ) - } - game.featuredImageUri.let { - put( - "featuredImageUri", - it.toStringAndSave(godot, "featuredImageUri", game.applicationId) - ) - } + put( + "hiResImageUri", + game.hiResImageUri?.toStringAndSave(godot, "hiResImageUri", game.applicationId) ?: "" + ) + put( + "iconImageUri", + game.iconImageUri?.toStringAndSave(godot, "iconImageUri", game.applicationId) ?: "" + ) + put( + "featuredImageUri", + game.featuredImageUri?.toStringAndSave(godot, "featuredImageUri", game.applicationId) ?: "" + ) }